Ensure DB connections are closed when we've finished with them #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babbageclunk
requested review from
davefellows,
matthchr,
Porges and
theunrepentantgeek
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1619 +/- ##
=======================================
Coverage 62.94% 62.94%
=======================================
Files 187 187
Lines 12359 12359
=======================================
Hits 7779 7779
Misses 3896 3896
Partials 684 684 Continue to review full report at Codecov.
|
babbageclunk
changed the title
This is much simpler than a cache of DBs. I started going down that path but as always it's removing no-longer needed DBs from the cache that makes it more complicated. For now this will fix the leak and if we have a problem with opening and closing connections being too slow we can fix that then.
This is much simpler than trying to use a DB cache for it.
In the azuresqlaction, azuresqlmanageduser and azuresqluser reconcilers.
The ASO CI subscription can't create servers in eastus2 but westus2 is allowed at the moment.
babbageclunk
force-pushed
the
bug/db-connection-leak
branch
from
650d598 to
ea608c2
Compare
Merged
Porges
approved these changes
Jul 6, 2021
matthchr
approved these changes
Jul 6, 2021
|
@matthchr @babbageclunk Is there already a timeline for the next release, which includes this fix? |
|
@johgoe There's no hard deadline but I would imagine sometime in the next week. Are you waiting for this change? (I assume yes given you're asking here). |
|
@matthchr Thank you for you fast reply. Currently we have to restart our PostgreSQL Server too often. We are happy to hear that the release should be available sometime next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1576
What this PR does / why we need it:
Before this change, the different resources would leak database connections whenever they were reconciled. Add
defer db.Close()to all of the places that open database connections so that they are closed at the end of the method.Special notes for your reviewer:
I started off making a cache to keep the
*sql.DBs in so that they could be reused between reconciliations, but then the difficulty was ensuring we didn't keep the DBs in the cache indefinitely. One option was to hook up the database controller so it could remove the cached entry when the database was deleted, but that's quite fiddly architecturally. I also wrote some code to clear DBs from the cache if they haven't been requested after a fixed amount of time, which would work but would be really difficult to test (to an extent that is probably not worth it).How does this PR make you feel:
